Repository navigation
Add comment on AbstractApi::$perPage() - #1007
Merged
Merged
Conversation
Contributor
|
👎 here. The new design has this immutable doesn't it? |
Collaborator
Author
|
Okey, Then I'll remove the Thank you for the feedback |
Nyholm
changed the title
Collaborator
Author
|
oops, Im wrong again. The |
Collaborator
|
Yes, the resultpager is now the "main" point of entry for paginating results so that's the why the See #907 for more context on this. Thanks for the extra comment and fixed tests! |
acrobat
approved these changes
May 20, 2021
Collaborator
|
Thank you @Nyholm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AbstractApi::setPerPage()was removed in the 3.0. I cannot find what PR that removed it.However, we kept
AbstractApi::$perPageand we do use it on a few places.. Im not sure if we should remove the property or add back the method.Also note, some integration tests are using
setPerPage().